Check threads

Ask Limn whether each open review thread was addressed by later commits.

On this page

Check threads is a light pass over the review threads that other people left on a pull request: teammates, review bots, and teammates' Limn. For each thread it answers two questions: does the comment hold up, and does the code now deal with it? It reads only the threads that changed since they were last judged, so it is quick and cheap.

#What it checks

Illustration: A judged thread: does the comment hold up, and where does the code stand.

A thread is checked when it has no current judgement:

  • it was never judged;
  • someone commented on it since it was judged;
  • it was resolved or reopened since; or
  • new commits arrived since.

Resolved threads are judged too, because resolving is only a click. Threads on your own Limn's findings are not part of this pass; a follow-up review or the replies pass looks after those. See Follow-up reviews and Replies to findings.

#The judgements

QuestionPills
Does the comment hold up?Holds up · Partly · Doesn’t hold · Unclear
Where does the code stand?Addressed · Partly addressed · Open · Resolved

Under the pills, one line says how the point was dealt with, or the one thing still needed. A thread with no judgement keeps Limn's own guess from the commits: Likely addressed, Replied or Untouched (see Thread states). The newest judgement wins, whichever review or check made it, and it shows on every thread card in Limn: the Threads tab, the Changes tab, the Feed and Pending.

#Run a check

Press Check threads beside Review threads on the AI Review tab, or on the pull request's Threads tab. A status line says what it is doing (Reading the threads, then "Checking 3 threads"), with Cancel. If there is nothing to check, Limn says so:

  • Every thread already has a current judgement.
  • This pull request has no review threads to check.
  • Every thread here is one of Limn’s own review comments. An AI review follows those up.

A full review judges the threads itself, so you do not need both. A review you start that Limn skips (no code changed) starts a thread check in its place.

#When it runs by itself

With auto review on for the workspace, a new comment by a person or a review bot in an open thread starts a check once the pull request has been quiet for 5 minutes. A new commit starts a full review instead. Automatic checks are limited to 30 a day per workspace and ask your spend budget first; checks you start do not count.

#What it changes

A thread check posts nothing to GitHub. Its judgements are used by the next review: a still-open point from a teammate's Limn can stop an approval, and a posted review may reply Still open: on a thread it judges valid and not addressed. A person's comment has no severity, so it never stops an approval by itself; the "Not approved" line names it. See Verdicts and posting to GitHub.